fix(elements): Errant renders upon sign-in completion #4225
Conversation
|
| @@ -146,34 +144,28 @@ export default function SignInPage() { | |||
| <CustomProvider provider='google'>Continue with Google</CustomProvider> | |||
| </div> | |||
|
|
|||
| {continueWithEmail ? ( | |||
There was a problem hiding this comment.
Just cleaning this up.
| @@ -426,7 +410,11 @@ export const SignInRouterMachine = setup({ | |||
| }, | |||
| 'FORM.ATTACH': { | |||
| description: 'Attach/re-attach the form to the router.', | |||
| actions: enqueueActions(({ enqueue, event }) => { | |||
| actions: enqueueActions(({ context, enqueue, event }) => { | |||
There was a problem hiding this comment.
Ensuring we don't attach a new formRef, and ultimately re-render, if it's not necessary.
| enqueue.raise({ type: 'NEXT', resource: event.output }); | ||
| }), | ||
| resetResource: assign({ resource: ({ context }) => context.clerk.client.signIn }), | ||
| setResource: assign({ |
There was a problem hiding this comment.
Rely on the returned SIA resource, over client.signIn
| @@ -1,5 +1,5 @@ | |||
| import { useClerk } from '@clerk/shared/react'; | |||
| import { useClerkHostRouter } from '@clerk/shared/router'; | |||
| import { useClerkHostRouter, useClerkRouter } from '@clerk/shared/router'; | |||
There was a problem hiding this comment.
Use useClerkRouter hook from shared vs the original local implementation.
| }, [clerk, exampleMode, formRef?.id, !!router, clerk.loaded]); | ||
| }, [Boolean(clerk), exampleMode, !!router, clerk.loaded]); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Limit the number of events sent by scoping the dependencies down.
tmilewski
force-pushed
the
tm/elements-consolidation
branch
from
c4550eb
to
2709db7
Compare
tmilewski
force-pushed
the
tm/elements-fix-errant-renders
branch
from
868e94b
to
874f4e2
Compare
tmilewski
force-pushed
the
tm/elements-consolidation
branch
from
2709db7
to
4e0f396
Compare
tmilewski
force-pushed
the
tm/elements-fix-errant-renders
branch
from
874f4e2
to
ab1b18c
Compare
tmilewski
force-pushed
the
tm/elements-consolidation
branch
from
4e0f396
to
6520328
Compare
tmilewski
force-pushed
the
tm/elements-fix-errant-renders
branch
from
ab1b18c
to
aa8e5f7
Compare
tmilewski
force-pushed
the
tm/elements-consolidation
branch
from
4dafbc6
to
ff29b34
Compare
Description
TODO
Fixes SDKI-144
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change