Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localizations): Fix building of retheme subpath exports #2245

Merged
merged 1 commit into from
Dec 4, 2023

Commits on Dec 2, 2023

  1. fix(localizations): Fix building of retheme subpath exports

    Before the localizations subpath exports change
    we had a single entrypoint, the `index`. Based
    on the CLERK_RETHEME env we were using the
    index.retheme.ts or the index.ts as entrypoint
    during build. To support that type of conditional
    output for all the exported subpaths we need to
    either define a callback to replace the *.retheme
    files with the *.ts files or conditional choose them
    in buiild configuration.
    Due to some issues with the tsup `onSuccess` callback
    i manually defined all the subpath exports.
    
    We need to be careful in the future and add the new
    localization files in both package.json#files, tsup.config.ts
    and in subpaths.mjs file to support subpath
    exports successfully
    dimkl committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    b4e4326 View commit details
    Browse the repository at this point in the history