Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localizations): Added missing key and en-US localization #2191

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

royanger
Copy link
Member

Description

Added missing parameter for localizations

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 7527af4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@royanger
Copy link
Member Author

I don't know if this warrants a changeset -- I can add one if needed.

Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we need to backport to v4 this change?

@nikosdouvlis nikosdouvlis merged commit 164ca11 into main Nov 23, 2023
7 checks passed
@nikosdouvlis nikosdouvlis deleted the roy/add-form_param_format_invalid__phone_number branch November 23, 2023 08:41
desiprisg pushed a commit that referenced this pull request Nov 23, 2023
* fix(localizations): Added missing key and en-US localization

* Create curvy-timers-play.md

---------

Co-authored-by: Dimitris Klouvas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants