Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Retheme <SignIn /> (part 1) #2179

Merged
merged 17 commits into from
Dec 12, 2023
Merged

[WIP] Retheme <SignIn /> (part 1) #2179

merged 17 commits into from
Dec 12, 2023

Conversation

marcelscruz
Copy link
Contributor

@marcelscruz marcelscruz commented Nov 21, 2023

Description

This PR includes a partial redesign of the <SignIn> component.

Descriptors:

cl-headerBackRowcl-backRow
cl-headerBackLinkcl-backLink
cl-headerBackIconRemoved altogether

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 1c4bd45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marcelscruz marcelscruz changed the title [WIP] Retheme sign-in [WIP] Retheme <SignIn /> Nov 21, 2023
@marcelscruz marcelscruz marked this pull request as ready for review December 12, 2023 14:42
@marcelscruz marcelscruz requested review from panteliselef, anagstef and desiprisg and removed request for panteliselef December 12, 2023 14:46
@marcelscruz marcelscruz changed the title [WIP] Retheme <SignIn /> [WIP] Retheme <SignIn /> (part 1) Dec 12, 2023
@anagstef anagstef added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 656d6ae Dec 12, 2023
9 checks passed
@anagstef anagstef deleted the retheme-sign-in branch December 12, 2023 17:05
octoper pushed a commit that referenced this pull request Dec 13, 2023
* feat(clerk-js): Add new design on sign-in initial card

* feat(clerk-js): Add new design on TOTP card

* fix(clerk-js): Wrong import and wrong icon style

* feat(clerk-js): Add fake continue on TOTP

* chore(clerk-js): Delete unused OTPInputLabel and OTPInputDescription

* chore(clerk-js): Re-add styles on card footer, submit button and identify preview

* feat(clerk-js): Add new design on alternative methods

* chore(clerk-js): Remove old back link from card header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants