-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLERK_RETHEME build issue on clerk-js #2127
Changes from all commits
d94616b
d0adc2d
363fd6d
d53ae01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--- | ||
--- |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "./tsconfig.declarations.json", | ||
"compilerOptions": { | ||
"paths": { | ||
"~ui/*": ["./ui.retheme/*"] | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,8 +20,10 @@ | |
"useUnknownInCatchVariables": false, | ||
"declaration": false, | ||
"jsx": "react-jsx", | ||
"jsxImportSource": "@emotion/react" | ||
// "noUncheckedIndexedAccess": true // TODO: Enable and progressively fix related errors | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nikosdouvlis Shall we add a ticket to bring There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This wasn't changed as part of this PR but agreed, let's add a ticket in triage |
||
"jsxImportSource": "@emotion/react", | ||
"paths": { | ||
"~ui/*": ["./ui/*"] | ||
} | ||
}, | ||
"include": [ | ||
"src/index.ts", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have the alias isn't it better to do
from '~ui/router'
?