Fix CLERK_RETHEME build issue on clerk-js #2127
Conversation
In order to be able to switch between /ui and /ui.retheme simply by changing the active tsconfig file
🦋 Changeset detectedLatest commit: d53ae01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -20,8 +20,10 @@ | |||
| "useUnknownInCatchVariables": false, | |||
| "declaration": false, | |||
| "jsx": "react-jsx", | |||
| "jsxImportSource": "@emotion/react" | |||
| // "noUncheckedIndexedAccess": true // TODO: Enable and progressively fix related errors | |||
There was a problem hiding this comment.
@nikosdouvlis Shall we add a ticket to bring noUncheckedIndexedAccess back ?
There was a problem hiding this comment.
This wasn't changed as part of this PR but agreed, let's add a ticket in triage
| import { runIfFunctionOrReturn } from '../../../utils'; | ||
| import { AlertIcon, Flex, Link, Text } from '../../customizables'; | ||
| import { useRouter } from '../../router'; |
There was a problem hiding this comment.
Now that we have the alias isn't it better to do from '~ui/router' ?
No, as even if we moved them, we'd still need to conditionally import from |
Description
Introduce the
~uipath alias on the build and type level (webpack and tsconfig) so we can conditionally build with or without the new UI components. The new alias was needed because wepathsin tsconfig will not work with relative imports, so we could not alias the top-level imports onindex.tsandindex.browser.tsChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore