Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add role_name field for organization invitation and membership #338

Merged
merged 2 commits into from
Oct 14, 2024
Merged

feat: add role_name field for organization invitation and membership #338

merged 2 commits into from
Oct 14, 2024

Conversation

NicolasLopes7
Copy link
Contributor

@NicolasLopes7 NicolasLopes7 commented Oct 13, 2024 •
edited
Loading

This pull request updates the organization_invitation and organization_membership models to include the role_name field

@NicolasLopes7 NicolasLopes7 requested a review from a team as a code owner October 13, 2024 22:49
gkats
gkats approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide an example of a response with both "role" and "role_name" fields set?

@NicolasLopes7 NicolasLopes7 force-pushed the nicolas/dash-430-need-access-to-role-name branch from ed16c05 to 0563705 Compare October 14, 2024 14:42
@NicolasLopes7 NicolasLopes7 merged commit 1c70b6d into v2 Oct 14, 2024
7 checks passed
@NicolasLopes7 NicolasLopes7 deleted the nicolas/dash-430-need-access-to-role-name branch October 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkats gkats gkats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasLopes7 @gkats