Reduce reliance on get_absolute_url
#244
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block above this line fetches the latest matching version, so it's pointless to then use that to get the latest version's URL. Instead, we get the URL of the object we already have.
This will allow us to add custom queryset methods in an upcoming commit.
Django models shouldn't know anything about URLs. This is a step in the direction of removing `get_absolute_url` from the models.
Before this change, we used a model helper method to fetch the URL of the latest version of a matching class. Now we fetch the latest version, and then get its URL.
Part of the process of removing the models is ensuring that we don't rely on any methods that live on them. This change removes most references to `get_absolute_url` on `Klass`, leaving behind those in the templates.
We're in the process of moving logic off the models. This model method was only used by one view. This moves the logic from the model to the view.
We were previously manually doing what defaultdict does for us.
Before this change, we didn't have a test which covered rendering overridden attributes. This change adds UpdateView to the snapshot tests, to catch regressions.
We previously tested against a couple of simple artificial examples, but I didn't trust it to cover all the possible cases. This change ensures that we're testing against a complicated real-world example, UpdateView, which I believe to represent sufficient complexity.
meshy
force-pushed
the
remove-url-knowledge-from-models
branch
from
5e1dc15
to
e9f1b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Split this PR into consumable chunks.