Split dependencies #237
Merged
Split dependencies #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghickman
force-pushed
the
split-dependencies
branch
from
c4eae37
to
a29aa78
Compare
This breaks up requirements.in into two files. The dev spec file, requirements.dev.txt, has a constraint on the compiled prod file so that we can both avoid duplicating requirements between the files but also avoid conflicting requirements. By doing a compile on new files we're going to get brand new versions, effectively doing an upgrade to everything. So this commit maintains the existing requirements.txt purely to constrain the compilation and avoid this situation.
Now that we've generated the split compiled files using the old requirements.txt as a constraint, we can remove that file, the constraint, and re-compile. This removes requirements.txt and updates the formatting for all requirements without bumping versions.
Note: pip-tools is making --strip-extras the default in 8.0, which uv has copied by default. This change also ensures a user has uv installed in the local venv so the tooling works, and can take advantage of the python that venv is using.
ghickman
force-pushed
the
split-dependencies
branch
from
a29aa78
to
14a5126
Compare
meshy
approved these changes
May 23, 2024
|
|
||
| e.g. (inside your virtualenv or whatever) | ||
|
|
||
| pip install -r requirements.txt | ||
| [uv] pip install -r requirements.prod.txt -r requirements.dev.txt |
There was a problem hiding this comment.
Suggestion: Perhaps we should be recommending make build here instead?
There was a problem hiding this comment.
Yes, I think there's a lot we can do here with a scripted stack to remove the need for most of this type of documentation and also use the same stack in CI. For example, [just|make] test would run the pytest installed in the correct venv in a way that a user could pass options to it locally.
There was a problem hiding this comment.
Cool OK -- I'll leave that for the readme fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't see any prod configuration in the repo, so the only change we'd need to make to deploy this is
s/requirements.txt/requirements.prod.txt/, and then we'd be installing several fewer packages.Locally, a user can now run
make compileto get updated requirements files. I'll look at scripting this further in the future so the compiled files and when to update them become an implementation detail, but for now, this moves us along nicely!Fix: #198