-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permutations #27
Permutations #27
Conversation
…rmutations Kept output in same object as permutation config so we dont have to sync names.
…tField So they can be reused outside ExperimentConfigForm
…nce configuration
The full config of the permutation then becomes the new reference config + permutation config. That should probably trigger a re-run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome progress! Here are some comments on the functionality so far, we can discuss them Thursday:
- Duplicate experiment should also duplicate permutations
- Shall we name the experiments as well, in the same way we now name the permutations
- I think we would want to be able to duplicate a permutation as well
- For the promote button, I envisioned it would replace the current reference instead of starting a new experiment. Perhaps we should support both?
There's a few open tasks including the UI, not relying on defaults in reference config, and todo's in code. I'd be happy to play a bit more with the layout later on.
Co-authored-by: Peter Kalverla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly looked through the code as well.
|
Refs #24
TODO
[x] - A reference configuration is complete (doesn't depend on defaults, i.e. all fields are defined explicitly)A reference configuration is complete (doesn't depend on defaults, i.e. all fields are defined explicitly) #32[X] - Visual hierarchy: reference should be above permutationsImprove layout experiment card #31[x] - Removing a permutation is okay. Removing an experiment is also okay, but should warn!Removing an experiment is also okay, but should warn! #33