Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permutations #27

Merged
merged 32 commits into from
Sep 23, 2024
Merged

Permutations #27

merged 32 commits into from
Sep 23, 2024

Conversation

sverhoeven
Copy link
Collaborator

@sverhoeven sverhoeven commented Sep 11, 2024

Refs #24

TODO

  • - An experiment can consist of multiple runs
  • - Each experiment has one reference configuration and zero or more permutations
  • [x] - A reference configuration is complete (doesn't depend on defaults, i.e. all fields are defined explicitly) A reference configuration is complete (doesn't depend on defaults, i.e. all fields are defined explicitly) #32
  • - A permutation defines one or more fields that should deviate from the reference. They are named.
  • - A run is a single execution of class with a given configuration.
  • - There are runs associated with both the reference and each permutation
  • - To execute a permutation, the reference config should be combined with the permutations to obtain a new, complete, configuration.
  • - ui
    • [X] - Visual hierarchy: reference should be above permutations Improve layout experiment card #31
    • - Permutations can display the difference from reference
    • - Adding a permutation should clearly be separated from cloning an experiment
    • - There should be an option to download an experiment as a json file
    • - There should be an option to download an experiment as zip, including the json file + one output csv per run
    • - Upload button should support uploading an experiment config json file
    • [x] - Removing a permutation is okay. Removing an experiment is also okay, but should warn! Removing an experiment is also okay, but should warn! #33
    • - It should be possible to promote a permutation to reference
  • Address TODO comments in code
  • Given you have a permutation what should happen when you change the reference configuration?

@sverhoeven sverhoeven changed the title 24 permutations Permutations Sep 12, 2024
Base automatically changed from layout-tweaks to main September 17, 2024 05:58
@Peter9192
Copy link
Member

  • Given you have a permutation what should happen when you change the reference configuration?

The full config of the permutation then becomes the new reference config + permutation config. That should probably trigger a re-run.

Copy link
Member

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome progress! Here are some comments on the functionality so far, we can discuss them Thursday:

  • Duplicate experiment should also duplicate permutations
  • Shall we name the experiments as well, in the same way we now name the permutations
  • I think we would want to be able to duplicate a permutation as well
  • For the promote button, I envisioned it would replace the current reference instead of starting a new experiment. Perhaps we should support both?

There's a few open tasks including the UI, not relying on defaults in reference config, and todo's in code. I'd be happy to play a bit more with the layout later on.

Copy link
Member

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly looked through the code as well.

apps/class-solid/src/components/Analysis.tsx Show resolved Hide resolved
apps/class-solid/src/components/Analysis.tsx Outdated Show resolved Hide resolved
apps/class-solid/src/lib/download.ts Outdated Show resolved Hide resolved
apps/class-solid/src/lib/store.ts Show resolved Hide resolved
apps/class-solid/src/routes/index.tsx Show resolved Hide resolved
@sverhoeven
Copy link
Collaborator Author

sverhoeven commented Sep 19, 2024

Awesome progress! Here are some comments on the functionality so far, we can discuss them Thursday:

  • Duplicate experiment should also duplicate permutations
  • Shall we name the experiments as well, in the same way we now name the permutations
  • I think we would want to be able to duplicate a permutation as well
  • For the promote button, I envisioned it would replace the current reference instead of starting a new experiment. Perhaps we should support both?

There's a few open tasks including the UI, not relying on defaults in reference config, and todo's in code. I'd be happy to play a bit more with the layout later on.

  1. yep
  2. yep, will also make permutation name editable
  3. will do
  4. will add swap with refence and promote to new experiment buttons. last buttonis current promote button.

@Peter9192 Peter9192 mentioned this pull request Sep 23, 2024
@sverhoeven sverhoeven marked this pull request as ready for review September 23, 2024 09:10
@sverhoeven sverhoeven merged commit 78e1adb into main Sep 23, 2024
4 checks passed
@sverhoeven sverhoeven deleted the 24-permutations branch September 23, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants