Skip to content

Commit

Permalink
Update removing keyboard observer comment (#64)
Browse files Browse the repository at this point in the history
  • Loading branch information
cjpearson committed Nov 15, 2017
1 parent 3e4af32 commit 6d2382e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/ios/CDVKeyboard.m
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ - (void)setHideFormAccessoryBar:(BOOL)hideFormAccessoryBar

- (void)setShrinkView:(BOOL)shrinkView
{
// When the keyboard shows, WKWebView shrinks window.innerHeight. This isn't helpful when we are already shrinking the frame
// They removed this behavior is iOS 10, but for 8 and 9 we need to prevent the webview from listening on keyboard events
// Remove WKWebView's keyboard observers when using shrinkView
// They've caused several issues with the plugin (#32, #55, #64)
// Even if you later set shrinkView to false, the observers will not be added back
NSNotificationCenter* nc = [NSNotificationCenter defaultCenter];
if ([self.webView isKindOfClass:NSClassFromString(@"WKWebView")]) {
Expand Down

0 comments on commit 6d2382e

Please sign in to comment.