Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cache size > 2000 #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dalmia
Copy link

@dalmia dalmia commented Dec 20, 2016

Fixes #80

This PR replaces long int with long long to support cache_size>2000.

Also, mentioned at scikit-learn/scikit-learn#8012

@TCharnley
Copy link

If the compiler being used is DevStudio don't the supporting/calling methods need to be modified as well. int get_data(const int index, Qfloat **data, int len); The int data type in this instance is still 4 bytes. To access additional cache size these also need to be 64 bit data types (--int64 / long long)
Does this effect building a 32 bit version with DevStudio?

@dalmia
Copy link
Author

dalmia commented Jan 4, 2017

@TCharnley Yes, this is indeed a confusion for me too. I think we should wait for someone to answer that.

@amueller
Copy link

amueller commented Mar 4, 2017

Shouldn't this be size_t #80 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants