add docs to SET_VEHICLE_LIGHTS #1187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,8 @@ void _SET_VEHICLE_LIGHTS_MODE(Vehicle vehicle, int p1); | |||
| ``` | |||
|
|
|||
| ``` | |||
| Could be SET_VEHICLE_HEADLIGHT_SHADOWS? | |||
There was a problem hiding this comment.
Any reason not to just rename this?
There was a problem hiding this comment.
not entirely sure about the name, was just a guess since its location kinda lined up, functionality wise i didn't test it
There was a problem hiding this comment.
Would be better off just not changing the file then imo.
AvarianKnight
added
the
needs validation
|
Closing in favor of #1192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the enum for SET_VEHICLE_LIGHTS and added a note for potential name to 0x1FD09E7390A74D54