Byte array support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruigouveiamaciel
changed the title
|
Additionally to this PR, it would be nice to add a proper deserialization method into CitizenFX.MsgPack, the current MsgPack implementation provides a public method to serialize data: CitizenFX.MsgPack.MsgPackSerializer.SerializeToByteArray(object value)but it doesn't provide a public method to deserialize data. I don't know how to implement that myself otherwise I would update this PR to include it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Add support for FiveM's custom MsgPack handling of byte arrays.
How This PR Achieves the Goal
Implemented the missing serializer and deserializer for byte arrays.
Issues Fixed
Fixes FiveM Issue #2571