Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for entity author #851

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add support for entity author #851

merged 1 commit into from
Aug 7, 2023

Conversation

abelsiqueira
Copy link
Collaborator

Pull request details

As a contributor I confirm

  • I read and followed the instructions in CONTRIBUTING.md
  • The developer documentation is up to date with the changes introduced in this Pull Request
  • Tests are passing
  • All the workflows are passing

List of related issues or pull requests

Refs:
Closes #286

Describe the changes made in this pull request

Implement entity as a possible author.
Rename the current Author to Person in many places.
Adds a new button to the author screen that allows creating an entity.
Adds update support to entity.
Update tests.

Instructions to review the pull request

Review the preview PR

@github-actions
Copy link

Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR851/

@abelsiqueira abelsiqueira marked this pull request as ready for review July 31, 2023 19:16
@abelsiqueira
Copy link
Collaborator Author

Hi @cgobat and @Martin15135215, can you check if this is working for you?

Copy link

@cgobat cgobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Existing entity authors parse as expected using the "update" option, and the interface to add/create new authors works well to and is nice and straightforward/intuitive. Thanks for your work on this!

@abelsiqueira
Copy link
Collaborator Author

Thanks for the review!

@abelsiqueira abelsiqueira merged commit 9b4e7c2 into main Aug 7, 2023
5 checks passed
@abelsiqueira abelsiqueira deleted the 286-entity branch August 7, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for entity author
2 participants