This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Stakeholder Bulk Upload. UPDATE: Move to Django #271
Draft
aloftus23
wants to merge
2
commits into
develop
Choose a base branch
from
AL-bulk-upload-dev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Check if the post request has the file part | ||
if "file" not in request.files: | ||
flash("No file part", "warning") | ||
return redirect(request.url) |
Check warning
Code scanning / CodeQL
URL redirection from remote source
Untrusted URL redirection due to [A user-provided value](1).
Untrusted URL redirection due to [A user-provided value](2).
Untrusted URL redirection due to [A user-provided value](3).
# empty file without a filename. | ||
if file.filename == "": | ||
flash("No selected file", "warning") | ||
return redirect(request.url) |
Check warning
Code scanning / CodeQL
URL redirection from remote source
Untrusted URL redirection due to [A user-provided value](1).
Untrusted URL redirection due to [A user-provided value](2).
Untrusted URL redirection due to [A user-provided value](3).
Untrusted URL redirection due to [A user-provided value](4).
This pull request introduces 4 alerts when merging fbebd0d into 78ccbfd - view on LGTM.com new alerts:
|
aloftus23
added
Draft PR
PR in draft mode, not passing checks
Production ready
Code passing checks, internal code review done, merged into staging environment and remove draft PR
labels
Oct 23, 2022
aloftus23
removed
Draft PR
PR in draft mode, not passing checks
Production ready
Code passing checks, internal code review done, merged into staging environment and remove draft PR
labels
Dec 21, 2022
Removing "Draft PR" and "Production ready" tags since this needs to be updated to fit the Django framework. |
aloftus23
changed the title
Stakeholder Bulk Upload into Flask UI
Stakeholder Bulk Upload. UPDATE: Move to Django
Dec 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #237
🗣 Description
Adds a page to the Flask UI that allows internal users to upload a CSV of stakeholders, which is then parsed and integrated into the P&E infrastructure (database and data sources).
UPDATE: Originally written for Flask, but needs to be changed to fit Django
💭 Motivation and context
P&E is going to start adding much more stakeholders at once so this improves automation.
🧪 Testing
Passes pre-commits and py-tests.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.