-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python Issues Flagged by pre-commit #82
Fix Python Issues Flagged by pre-commit #82
Conversation
…ocstrings in mitmproxy test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted a few things that should be taken care of before I can approve this PR, as well as a couple of things that don't apply to this PR specifically, but I felt I should mention.
…st_pipelines.py and test_main_spider.py.
… and .mypy_cache to .gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the items that I mentioned - looks good now! 👍
Approved with same caveat as #32:
@Matthew-Grayson stated that the remaining automated test failures will be addressed in future PRs.
@dav3r Of Course! |
🗣 Description
.github Changes
Integrate .env file into test_python job in backend.yml. This enables us to remove the public/private keys in mitmproxy_sign_requests.py and test_mitmproxy_sign_requests.py.
Note: this is a test RSA private key and not used in any deployed environment.
Other Changes
for test filesConfigure flake8 to skip checking for docstrings in test filesotherpython modules and functions💭 Motivation and context
Closes issue #77
All python-related pre-commit hooks now pass.
🧪 Testing
Unit tests pass.
The following pre-commit checks pass:
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist