Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced "info" icon in User Logs (CRASM-759) #684

Closed

Conversation

hawkishpolicy
Copy link
Collaborator

  • Current "info" icon is rendering oddly and it does not match the icon buttons used in other tables throughout the app.

🗣 Description

  • Replaced "info" icon with "OpenInNewIcon" to match other tables throughout the app.

💭 Motivation and context

🧪 Testing

  • Tested locally.

📷 Screenshots (if appropriate)

Screenshot 2024-10-09 at 11 05 35 AM
Screenshot 2024-10-09 at 3 36 04 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy hawkishpolicy self-assigned this Oct 9, 2024
@hawkishpolicy hawkishpolicy deleted the Replace-"Details"-icon-button-in-User-Logs branch October 9, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant