Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes the removed MediaStream.stop() for chrome 47 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzzk
Copy link

@zzzk zzzk commented Dec 22, 2015

Mediastream.stop() is deprecated since Chrome 45 and does not work anymore with Chrome 47. This pull request fixes the issue in calling stop() for each track of the stream. Note you can reproduce the error with the capture example implementation of https://cirocosta.github.io/qcode-decoder/

…nymore in Chrome 47 (https://developers.google.com/web/updates/2015/07/mediastream-deprecations?hl=en)

fixed stopping each track individually. See also https://developer.mozilla.org/en/docs/Web/API/MediaStream for browser compatibility. Library  gulp-livereload was missing for building the sources.
@zzzk zzzk force-pushed the master branch 2 times, most recently from 7b1468a to 39af7cc Compare December 22, 2015 08:28
@zzzk
Copy link
Author

zzzk commented Dec 22, 2015

Hi Ciro,
tests fail due to the missing credentials of the test framework, locally they run ok
severin

@stoeffel
Copy link

stoeffel commented Jan 4, 2016

@cirocosta Is there something that I can do to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants