If get through system readline library under, don't need -l flag.

cindytsai · Apr 12, 2024 · ca249e3 · ca249e3
1 parent 4c126b6
commit ca249e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -47,7 +47,7 @@ target_link_libraries(yt PRIVATE
         ${Python_LIBRARIES}
         Python::NumPy
         $<$<BOOL:${INTERACTIVE_MODE}>:${Readline_LIBRARY}>
-        $<$<BOOL:${INTERACTIVE_MODE}>:${Readline_LIBFLAGS}> # TODO: need to read from readline.pc Requires.private and Requires
+        $<$<BOOL:${INTERACTIVE_MODE}>:${Readline_LIBFLAGS}>
         $<$<BOOL:${JUPYTER_KERNEL}>:xeus-zmq>
 )
 

diff --git a/vendor/CMakeLists.txt b/vendor/CMakeLists.txt
@@ -23,8 +23,7 @@ if (Readline_INCLUDE_DIR AND Readline_LIBRARY)
         execute_process(COMMAND pkg-config --libs readline --static OUTPUT_VARIABLE Readline_LIBFLAGS OUTPUT_STRIP_TRAILING_WHITESPACE)
         set(Readline_LIBFLAGS ${Readline_LIBFLAGS} PARENT_SCOPE)
     else ()
-        execute_process(COMMAND pkg-config --libs readline --static OUTPUT_VARIABLE Readline_LIBFLAGS OUTPUT_STRIP_TRAILING_WHITESPACE)
-        set(Readline_LIBFLAGS ${Readline_LIBFLAGS} PARENT_SCOPE)
+        set(Readline_LIBFLAGS "" PARENT_SCOPE)
     endif ()
     message(STATUS "Found readline: ${Readline_LIBRARY} (link flags: ${Readline_LIBFLAGS})")
 else ()