Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next meeting fix #133

Merged
merged 8 commits into from
Sep 23, 2023
Merged

Next meeting fix #133

merged 8 commits into from
Sep 23, 2023

Conversation

agilous
Copy link
Member

@agilous agilous commented Sep 22, 2023 •
edited
Loading

Issue: Some changes in the name property of the meetings being returned by the Meetup.com API caused no meetings to be parsed.

Fix: Did the following:

  • address slight change in Meeting.com event names
  • schema.rb was updated due to ActiveRecord::Schema version change
  • use rails generated bin scripts for rails and rake commands
  • handle gem issues including:
    • remove webdrivers
    • fix rails and puma vulnerabilties
    • bin scripts updated during bundler run (except rails and rake)
  • fancify the ci script

@agilous
github action fix & rubocop issues
0a85f87 
* Capybara/ClickLinkOrButtonStyle
* Capybara/RSpec/HaveSelector
* Rails/RedundantActiveRecordAllMethod
* RSpec/Rails/HaveHttpStatus
* RSpec/Rails/HttpStatus
* RSpec/Rails/InferredSpecType
* Style/RedundantConstantBase
@agilous agilous merged commit 1d5e81f into main Sep 23, 2023
3 checks passed
@agilous agilous deleted the next-meeting-fix branch September 23, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilous @tmecklem