Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidying up #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tidying up #99

wants to merge 2 commits into from

Conversation

rtanaka
Copy link
Contributor

@rtanaka rtanaka commented Nov 8, 2018

note - if you accept this PR, i'll need your help to add the links I removed from the README into the wiki. it would be good to add another option to purchase the raspberry pi zero from sparkfun since the amazon one is not cost effective - https://www.sparkfun.com/products/14277

@cimryan
Copy link
Owner

cimryan commented Nov 9, 2018

Can you help me understand the motivation for removing the links from the hardware section?

I usually treat file and directory names as atomic entities. I like to be able to search in the code for them. So, I don't see redundancy in get_archive_module.

@rtanaka
Copy link
Contributor Author

rtanaka commented Nov 9, 2018

Can you help me understand the motivation for removing the links from the hardware section?

The readme, imho, should be streamlined to get someone set up.

You created a Wiki page with optional hardware so it made sense to me that we move all hardware links over to that wiki -- especially the optional items. We can link the actual items from the Readme to the Wiki once those pages exists.

I usually treat file and directory names as atomic entities. I like to be able to search in the code for them. So, I don't see redundancy in get_archive_module.

hmm.. okay. so, we can just leave it as is then or my other preference would be to make it an associative array instead. i can update the pull request later for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants