Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search.js DOM text reinterpreted as HTML #742

Closed
wants to merge 1 commit into from

Conversation

Shivam7-1
Copy link

Please describe what your Pull Request does

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.

@Shivam7-1 Shivam7-1 requested a review from a team as a code owner May 3, 2024 15:50
@Snugug
Copy link
Collaborator

Snugug commented May 3, 2024

Hey @Shivam7-1, thank you for your enthusiasm and your feedback here! You've opened a number of PRs against a number of our repositories with the same description fixing the same non-issue; while innerHTML can be an XSS issue when inserting untrusted content, that is not the case here or in the other PRs you've created. I'm going to close this, and the other similar PRs you've created, and ask you to refrain from filing any more similar PRs against our repositories.

Thank you.

@Snugug Snugug closed this May 3, 2024
@Shivam7-1
Copy link
Author

Shivam7-1 commented May 3, 2024

Hi @Snugug
Thanks For Reviewing This PR and Feedback

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants