Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝(content) Post: ADB over Wi-Fi and Ethernet #644

Merged
merged 15 commits into from
Aug 24, 2023
Merged

Conversation

jkcinouye
Copy link
Collaborator

Content added to posts:
ADB over Wi-Fi and Ethernet

posts/adb-over-wifi.md

ADB over Wi-Fi and Ethernet
@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Visit the preview URL for this PR (updated for commit 3e0667f):

https://cros-staging--pr644-content-adb-over-wif-qgrucbbe.web.app

(expires Sat, 23 Sep 2023 20:49:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 885bb271e567405677d117cfd5af5c57785d13e2

@jkcinouye jkcinouye marked this pull request as ready for review August 23, 2023 17:24
@jkcinouye jkcinouye requested a review from a team as a code owner August 23, 2023 17:24
@Snugug Snugug changed the title 📝(content) Post: ADB over Wi-Fi 📝(content) Post: ADB over Wi-Fi and Ethernet Aug 24, 2023
Copy link
Collaborator

@Snugug Snugug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two items:

  • This is Android documentation, should live in android instead of posts
  • Images need to have their URLs updated

posts/adb-over-wifi.md
site/en/posts/adb-over-wifi.md ->
site/en/android-adb-over-wifi.md
@jkcinouye jkcinouye requested a review from Snugug August 24, 2023 18:45
Copy link
Collaborator Author

@jkcinouye jkcinouye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images added!
URL changed!

@fuentespatrick
Copy link
Contributor

The other ADB content lives here: https://chromeos.dev/en/android-environment/deploying-apps
Do we want to keep them together and/or reference them from each other?

Copy link
Collaborator

@Snugug Snugug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, found a few more things when looking at the updated items actually rendered. These should all be click to fix.

site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
site/en/android/adb-over-wifi.md Outdated Show resolved Hide resolved
jkcinouye and others added 11 commits August 24, 2023 15:04
	renamed:    site/en/android/adb-over-wifi.md -> site/en/android-environment/adb-over-wifi.md
	modified:   site/en/android-environment/adb-over-wifi.md

Weighting content in order to group ADB content.
Snugug
Snugug previously approved these changes Aug 24, 2023
	renamed:    site/en/android-environment/adb-over-wifi.md -> site/en/android-environment/adb-over-wifi-and-ethernet.md
@Snugug Snugug merged commit 4041deb into main Aug 24, 2023
11 checks passed
@Snugug Snugug deleted the content/adb-over-wifi branch August 24, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants