Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of check_zero() in forceNetwork() and sankeyNetwork() #282

Closed
wants to merge 1 commit into from
Closed

Fix use of check_zero() in forceNetwork() and sankeyNetwork() #282

wants to merge 1 commit into from

Commits on Apr 10, 2021

  1. Fix use of check_zero() in forceNetwork() and sankeyNetwork() 

    Calling `check_zero()` too early in the function resulted in a bug where 1-indexed input would not be detected if either:

* `Links` was not a `data.frame`
* `Source` or `Target` were missing

Moving `check_zero()` further down the functions and adding missing input checks for `forceNetwork()` fixes the issue.
    @lewinfox
    lewinfox committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    161a22e View commit details
    Browse the repository at this point in the history