Make {start|end}_pIC50 optional in JSON schema
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcwitt
reviewed
Sep 8, 2020
covid_moonshot/core.py
Outdated
| @@ -78,6 +77,8 @@ class RunDetails: | |||
| start_smiles: str | |||
| start_title: str | |||
| target: str | |||
| end_pIC50: float = None | |||
| start_pIC50: float = None | |||
There was a problem hiding this comment.
Nice! Sorry about this, I was worried we might have a problem here but convinced myself it was ok.
BTW, if we make the type Optional[float] here, we'll get warnings from mypy when we try to use start_pIC50 without first checking if it is None.
|
@mcwitt is this PR now outdated by the new spec? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables sprint-3 JSON files to work with the current pipeline by making
{start|end}_pIC50optional in the JSON schema.