Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.7, add 3.10 to CI #161

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Nov 16, 2021

In line with NEP29: https://numpy.org/neps/nep-0029-deprecation_policy.html

Merge after 2021.12.26.

Status

  • Ready to go

@dotsdl
Copy link
Member Author

dotsdl commented Feb 1, 2022

Scratching my head on what we're seeing for Python 3.10 CI:

Updating 'fah-xchem' env from conda env update...
  /usr/share/miniconda/condabin/mamba env update --name fah-xchem --file /home/runner/work/fah-xchem/fah-xchem/devtools/conda-envs/setup-miniconda-patched-test.yaml
  
  
  Looking for: ['fire', 'jinja2', 'joblib', 'matplotlib', 'mdtraj', "numpy[version='>=1.19']", 'openeye-toolkits', 'openmm', 'openmmtools', "pandas[version='>=1.1']", 'perses', 'plotly', 'pydantic', 'pymbar', "python[version='>=3.6']", 'rich', "seaborn[version='>=0.11']", 'simplejson', 'networkx', 'beautifulsoup4', 'pip', 'pytest', 'pytest-cov', 'codecov', 'arsenic', 'python=3.10']
  
  
  Encountered problems while solving:
    - nothing provides python 3.3* needed by pymbar-3.0.0.beta1-np19py33_1
  
  pkgs/main/noarch          
  pkgs/r/linux-64           
  pkgs/r/noarch             
  openeye/linux-64          
  openeye/noarch            
  pkgs/main/linux-64        
  omnia/noarch              
  omnia/linux-64            
  conda-forge/noarch        
  conda-forge/linux-64   

Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dotsdl
Copy link
Member Author

dotsdl commented Mar 4, 2022

Still not sure why we're getting failures on python 3.10. I originally thought this could be due to OpenMM (openmm/openmm#3456), but since there are now conda packages for OpenMM for python 3.10 this doesn't seem to be the case. We're still seeing the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants