Updated to work with Puppet 4 and updated IIS module #5
Conversation
gceraso
commented
Aug 29, 2016
gceraso
commented
- Updated syntax to match IIS module.
- Cleaned up and minimized variables
- Removed params class and simplified module
- Sanitized indents.
|
This is a good start. I'll review what's included here. |
| $server_install_location = 'C:\tools\chocolatey.server', | ||
| $chocolatey_server_app_pool_name = 'chocolatey.server', | ||
| $chocolatey_server_app_port = $port, | ||
| ) { |
There was a problem hiding this comment.
We prefer the params pattern because it allows for hiera values. It's possible this will also allow that, but I'm unsure. And keep in mind this should also continue to work with v3.
There was a problem hiding this comment.
Because these are now parameterized, they will still be looked up via hiera.
There was a problem hiding this comment.
Will that still be compatible with both versions? Having the extra logic here doesn't hurt anything that I'm aware of, so I'm not ready to modernize until v3 EOLs completely.
There was a problem hiding this comment.
Automatic parameter lookup also works in v3.
There was a problem hiding this comment.
Well then there really isn't a reason to be doing params pattern then. Unless there is something I'm not thinking of offhand
There was a problem hiding this comment.
Yeah. AFAIK Puppet recommends not using params pattern going forward.
|
You have not addressed https://github.com/chocolatey/puppet-chocolatey_server/blob/master/metadata.json#L48 yet. |
| app_pool => 'DefaultAppPool' | ||
| iis_site {'Default Web Site': | ||
| ensure => stopped, | ||
| app_pool => 'DefaultAppPool' |
There was a problem hiding this comment.
This is a different change than what the module originally did. It removed the default website. Are you proposing to just stop it instead?
There was a problem hiding this comment.
I am simply because there is a bug which I meant to include. When no sites exist, this creates an issue. voxpupuli/puppet-iis#123
|
As for https://github.com/chocolatey/puppet-chocolatey_server/blob/master/metadata.json#L48 I'm trying to locate when the syntax changed. Do you have a preference here, I can point the latest version. |
|
@gceraso I think if we can determine what version of IIS, we can maintain compat with the old and the new. |
|
The best I can gather is it seems the syntax changed for "2015-05-22 - Release 1.4.1" |
|
Wow, syntax change and not a major version bump?! |
|
Unless they left it compatible with the older method of calling iis_site? |
|
Seems like that's when they started their rewrite. The 2.0 release seems to be when they cut support for the old syntax. |
|
Okay, whew... 👍 |
|
Updated the metadata file with the relevant versions for IIS. |
|
The currently used IIS module is deprecated since August 2017. The module now refers to the supported PuppetLabs IIS module. |
|
👍 |
|
when is this going to be merged? puppet-iis is already deprecated |
|
Any update here regarding the dependancy on puppet/iis? |
