(GH-70) Provide Chocolatey Language Server support #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
previously requested changes
Feb 14, 2019
src/Chocolatey.Language.Server/Validations/UrlValidValidation.cs
Outdated
Show resolved
Hide resolved
mkevenaar
changed the title
- Added UrlValidValidation rules for all Url elements. - Added generic url_is_valid function
|
@mkevenaar I have merged this here: gep13@65cde42 The branch needs a rebase after bringing in some of the changes that @steviecoaster made, and also I made a slight modification to how it works. Nothing major though, just a minor tweak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#70
Motivation and Context
Added all Url validation
How Has This Been Tested?
Local debugging.
Screenshots (if appropriate):
Types of changes
Checklist: