Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-70) Validates that the author does not match the maintainer #176

Merged
merged 1 commit into from
Mar 16, 2019
Merged

(GH-70) Validates that the author does not match the maintainer #176

merged 1 commit into from
Mar 16, 2019

Conversation

mkevenaar
Copy link
Member

Description

Validates that the author does not match the maintainer

Related Issue

#70

Motivation and Context

Part of the solution

How Has This Been Tested?

Local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mkevenaar mkevenaar changed the title (GH-70) Validates that the author does not match the maintainer [WIP] (GH-70) Validates that the author does not match the maintainer Mar 10, 2019
@mkevenaar mkevenaar changed the title [WIP] (GH-70) Validates that the author does not match the maintainer (GH-70) Validates that the author does not match the maintainer Mar 10, 2019
@mkevenaar mkevenaar marked this pull request as ready for review March 10, 2019 10:26
AdmiringWorm
AdmiringWorm approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gep13
gep13 approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit d11d56c into chocolatey-community:develop Mar 16, 2019
@gep13
Copy link
Member

gep13 commented Mar 16, 2019

@mkevenaar your changes have been merged, thanks for your contribution 👍

gep13 pushed a commit that referenced this pull request Mar 16, 2019
@web-flow
AppVeyor Publish: d11d56c
f625c38 
Merge pull request #176 from mkevenaar/feature/GH-70/AuthorDoesNotMatchMaintainerNote

(GH-70) Validates that the author does not match the maintainer
@mkevenaar mkevenaar deleted the feature/GH-70/AuthorDoesNotMatchMaintainerNote branch October 1, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

@AdmiringWorm AdmiringWorm AdmiringWorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkevenaar @gep13 @AdmiringWorm