(GH-70) Implemented validation rule to check if icon url is svg or png #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only so we don't have to add the DocumentationUrl ourself every time we add a new rule. Since every rule name follow the same naming scheme, there is no need to override the DocumentationUrl in every class.
|
@AdmiringWorm I actually had the same thought about moving the documentation url in the base class. This is a good add! |
|
@AdmiringWorm your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented rule to check if the icon url used is using a png or a svg file extension.
Related Issue
#70
Motivation and Context
Locally
How Has This Been Tested?
Locally
Screenshots (if appropriate):
Types of changes
Checklist: