(GH-70) Changed to use relative paths to language server #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adds the code to iterate through an array of paths to check for the expected Language Server.
|
@AdmiringWorm your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way that detection of the Language Server dll is used.
With this change, the path doesn't need to be changed for every new contributor of the extension (only needs to be built).
As a benefit, it's easy to change up which paths that will be checked as well.
Related Issue
Relates to #70
Motivation and Context
Motiviation was to not needing to change the path for every time I needed to test the Language Server
How Has This Been Tested?
Locally
Screenshots (if appropriate):
Types of changes
Checklist:
Additional notes
This is not original code, and all credits should go to the developer of the following example repo: https://github.com/CXuesong/LanguageServer.NET (Licensed under Apache 2.0)