(GH-70) Minor tweaks

- Switch to using an extension method
- Corrected whitespace

src/Chocolatey.Language.Server/Utility/Utility.cs → src/Chocolatey.Language.Server/UriExtensions.cs

@@ -3,21 +3,23 @@
 
 namespace Chocolatey.Language.Server.Utility
 {
-
-    public class Utility
+    /// <summary>
+    ///   Extensions for Uri
+    /// </summary>
+    public static class UriExtensions
     {
-
         /// <summary>
         ///   Tries to validate an URL
         /// </summary>
         /// <param name="url">Uri object</param>
-        public static bool url_is_valid(Uri url)
+        public static bool IsValid(this Uri url)
         {
             var request = (HttpWebRequest)WebRequest.Create(url);
 
-            request.Timeout = 15000;
             //This would allow 301 and 302 to be valid as well
             request.AllowAutoRedirect = true;
+            request.Timeout = 15000;
+
             try
             {
                 using (var response = (HttpWebResponse)request.GetResponse())
@@ -29,6 +31,6 @@ public static bool url_is_valid(Uri url)
             {
                 return false;
             }
-        }        
+        }
     }
-}
+}

src/Chocolatey.Language.Server/Validations/UrlValidValidation.cs

@@ -14,7 +14,6 @@ namespace Chocolatey.Language.Server.Validations
     /// TODO: Add <seealso> elements once PR is merged
     public class UrlValidValidation : INuSpecRule
     {
-
         private static readonly IReadOnlyCollection<string> UrlElements = new []
         {
             "bugTrackerUrl",
@@ -37,10 +36,11 @@ public IEnumerable<Diagnostic> Validate(XmlDocumentSyntax syntaxTree, TextPositi
                     Uri uri;
                     if(
                         !Uri.IsWellFormedUriString(uriString, UriKind.Absolute) ||
-                        !Uri.TryCreate(uriString, UriKind.Absolute, out uri) || 
-                        !Utility.Utility.url_is_valid(uri)
+                        !Uri.TryCreate(uriString, UriKind.Absolute, out uri) ||
+                        !uri.IsValid()
                     ) {
                         var range = textPositions.GetRange(element.StartTag.End, element.EndTag.Start);
+
                         yield return new Diagnostic {
                             Message = "Url in " + elementName + " is invalid. See https://github.com/chocolatey/package-validator/wiki/InvalidUrlProvided",
                             Severity = DiagnosticSeverity.Error,
@@ -51,4 +51,4 @@ public IEnumerable<Diagnostic> Validate(XmlDocumentSyntax syntaxTree, TextPositi
             }
         }
     }
-}
+}