Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(zotero) add 64-bit installer #2546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

teknowledgist
Copy link
Contributor

This adds the new install option for 64-bit Zotero and simplifies the update a bit.

Description

Modified the update.ps1 to grab both 32-bit and 64-bit installer URLs, download the EXEs and replace the information in the VERIFICATION.txt file. Modified chocolateyinstall.ps1 to install either 32-bit or 64-bit flavor of Zotero. Also simplified the VERIFICATION.txt file and chocolateyinstall.ps1 and chocolateyuninstall.ps1 files to require fewer (or no) edits via update.ps1. Re-arranged metadata in the .nuspec to match the order of a new package. Updated the LICENSE.txt file to match changes at the project.

Motivation and Context

32-bit Zotero works fine on 64-bit systems, but regularly pops up a dialog indicating that it's not the most efficient version for the environment. The upgrade from 32-bit to 64-bit is as simple as a re-install, so fixing this package to have both bit-levels was fairly straightforward.

How Has this Been Tested?

Installed the current, 32-bit-only, v7.0.5 package then upgraded to proposed v7.0.5.20240930 package with no trouble. Also installed the proposed package without upgrading. Uninstalls worked too.

This was on Win11 system with Chocolatey v2.3.0. There is no reason to suspect the official test environment would have any issues because the script functions are exactly the same, just with the addition of the 64-bit installer. I don't have ready access to the official test environment, so someone else will have to test that if it is absolutely necessary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

This adds the new install option for 64-bit Zotero and simplifies the update a bit.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants