Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cyg-get) Space in $cygRoot #2495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jccolson
Copy link

@jccolson jccolson commented Jun 27, 2024

Correct a bug when $cygRoot contain space.

Description

Adding some " to allow space in variable $cygRoot.

Motivation and Context

If CygWin is installed in "C:\Program Files\CygWin64", "cyg-get firefox" install defaults packages and firefox in the directory "C:\Program".

#2489

How Has this Been Tested?

choco install -y --params "/InstallDir:'C:\Program Files\CygWin64' /site:'ftp://ftp-stud.hs-esslingen.de/pub/Mirrors/sources.redhat.com/cygwin/'" Cygwin
choco install -y cyg-get
cyg-get install firefox

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

Correct a bug when $cygRoot contain space.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@pauby
Copy link
Member

pauby commented Jun 27, 2024

Please go back to the description and amend it to provide the correct information and ensure you read the required guidelines and make the necessary changes.

@jccolson jccolson changed the title Update cyg-get.ps1 (cyg-get) Space in $cygRoot Jun 28, 2024
@jccolson
Copy link
Author

@pauby I don't know how to complete "Open issues" in "Original Location".
I have put the link to the issue in "Motivation and Context".

@pauby
Copy link
Member

pauby commented Jun 29, 2024

The last bit needs to be removed. As the comments on the template indicate, its only for migrations.

Not that I haven't looked at this package for this PR, but it may be necessary for a new package to be released manually.

@jccolson
Copy link
Author

@pauby Can I help you to create the new version ?

@pauby
Copy link
Member

pauby commented Jul 12, 2024

@jccolson I'm not sure what you are asking. I am not creating a new version.

@jccolson
Copy link
Author

@pauby You say : "it may be necessary for a new package to be released manually". It's not a new version of cyg-get package ?

@pauby
Copy link
Member

pauby commented Jul 12, 2024

"it may be necessary for a new package to be released manually". It's not a new version of cyg-get package ?

I understand now. Thanks for clarifying.

I am unlikely to be releasing the new package. Whoever picks up this PR to review will likely do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants