(webstorm) Strip .0 suffix from installation directory
#2367
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining the installation directory for Webstorm, remove any `.0` suffix that might be present in the version number. Jetbrains doesn't use this part of the release version number when installing, so this causes Chocolatey to create an empty directory that never gets used or cleaned up. Fixes issue chocolatey-community#2266 .
|
✅ Package verification completed without issues. PR is now pending human review |
pauby
reviewed
Dec 21, 2023
Comment on lines
+9
to
14
| # If the release version ends in '.0', remove this since JetBrains don't | ||
| # use this part of the version number when creating the installation directory. | ||
| $installDir = "$programFiles\JetBrains\WebStorm $($env:ChocolateyPackageVersion -replace '.0$', '')" | ||
| if ($pp.InstallDir) { | ||
| $installDir = $pp.InstallDir | ||
| } |
There was a problem hiding this comment.
Same comment as over on the datagrip PR:
We're creating the directory further down on line 19. Can we not just remove that line and let the installer install wherever it thinks it should? Why do we need to create the directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When determining the installation directory for Webstorm, remove any
.0suffix that might be present in the version number. Jetbrains doesn't use this part of the release version number when installing, so this causes Chocolatey to create an empty directory that never gets used or cleaned up.Motivation and Context
Fixes: #2266
How Has this Been Tested?
choco install -s . webstormwith these changes; observe that spurious.0directory is no longer created.Types of changes
Checklist: