Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(pencil) Fix update script and installation #2317

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

Windos
Copy link
Member

@Windos Windos commented Oct 1, 2023

Description

This PR adjusts the pencil update script so that it works correctly, and also updates the chocolateyInstall.ps1 script and VERIFICATION.txt to reflect these changes.

This PR also expands a number of aliases in the pencil update script.

Motivation and Context

At the moment the update for this package fails, due to the assumption that there is a separate 32-bit and 64-bit installers for Windows. This is no longer the case and there is only a single installer for Windows now.

This failure has been noted in #2187.

How Has this Been Tested?

On a vanilla Windows 10 (fully patched) test VM I verified that running the pencil packages' update.ps1 script fails with the same error as seen when run via this repository's automation.

I retested after making these changes and verified that the update.ps1 script succeeded.

The resulting nupkg successfully installed the pencil application on my test VM, and also in my local copy of Chocolatey test environment.

Screenshot (if appropriate, usually isn't needed):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up.

automatic/pencil/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@pauby pauby merged commit 8159d3d into chocolatey-community:master Oct 3, 2023
1 check passed
@pauby
Copy link
Member

pauby commented Oct 3, 2023

@Windos awesome work! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants