Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(universal-usb-installer) Treat trailing character as a additional version number #2198

Merged

Conversation

AdmiringWorm
Copy link
Member

Description

This pull request updates the automatic updater to treat any trailing character
as its own number to be appended to the last version part, this allows us to
create a new package version even when the software developer has created
a new version without using a pure version number.

ref #2187

Motivation and Context

To have a working automatic updater

How Has this Been Tested?

  1. Run .\update_all.ps1 universal-usb-installer
  2. Verify it updated to 2.0.1.4100 (those last zeros are the fix version part)

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment (Not changing any package scripts).
  • The changes only affect a single package (not including meta package).

…rsion number

This commit updates the automatic updater to treat any trailing character
as its own number to be appended to the last version part, this allows us to
create a new package version even when the software developer has created
a new version without using a pure version number.

ref chocolatey-community#2187
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Contributor

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The code works to update a package today, but the current version isn't one that would be affected by the code change. Running through it, it seems like it should work.

@JPRuskin JPRuskin merged commit a0ebc3d into chocolatey-community:master May 24, 2023
@AdmiringWorm AdmiringWorm deleted the universal-usb-installer-fix branch May 24, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants