Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(libreoffice) Clarify package update lagging behind software release and where to raise issues / questions #1804

Conversation

pauby
Copy link
Member

@pauby pauby commented Feb 21, 2022

Description

I've updated the README*.md files for libreoffice. These should flow into the 'description` in the .nupspec file.

Note that how we add this info, the message and the formatting are all up for debate. I wanted to get something up here for discussion. Once agreed, I feel we should require any updates to a package to add this to the README files (perhaps by adding it to #1754).

Closes #1803.

Motivation and Context

Questions are still being asked via Disqus for many packages. As Disqus is generally not responded to it makes sense to clarify where questions and issues should be raised. Going forward we should add this to all packages.

How Has this Been Tested?

I haven't tested this as it was an update to Markdown.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@pauby pauby force-pushed the doc/libreoffice-where-raise-issue-question branch from eaf1a6e to 8a76f16 Compare February 21, 2022 08:34
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@pauby
Copy link
Member Author

pauby commented Feb 21, 2022

This looks to be a build automation issue.

image

Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting issues that needs to be fixed, otherwise this looks good to me.

automatic/libreoffice-streams/README.fresh.md Outdated Show resolved Hide resolved
automatic/libreoffice-streams/README.md Outdated Show resolved Hide resolved
automatic/libreoffice-streams/README.still.md Outdated Show resolved Hide resolved
@pauby
Copy link
Member Author

pauby commented Feb 22, 2022

Thanks @AdmiringWorm. I'll get that space removed (can't believe I didn't see it! 😄 ). I'll fixing up the other PR's too as they will likely have the same issue.

@AdmiringWorm
Copy link
Member

@pauby I have fixed it up on the other PR's you made, I didn't notice the space until after I had merged those.

@pauby pauby force-pushed the doc/libreoffice-where-raise-issue-question branch from 8a76f16 to 9afd329 Compare February 23, 2022 10:48
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@pauby
Copy link
Member Author

pauby commented Feb 23, 2022

Updated this PR with those changes.

@pauby I have fixed it up on the other PR's you made, I didn't notice the space until after I had merged those.

If it's not going to render properly in those other packages, do you want me to fix them?

@pauby
Copy link
Member Author

pauby commented Feb 23, 2022

@AdmiringWorm Going to put this into Draft just now as I may as well add this to it while I'm here.

@pauby pauby marked this pull request as draft February 23, 2022 11:48
Questions are still being asked via Disqus for many packages. As Disqus is generally not responded to it makes sense to clarify where questions and issues should be raised. The update of this package lags behind the software release. So we should clarify how this works.
@pauby pauby force-pushed the doc/libreoffice-where-raise-issue-question branch from 9afd329 to 5ebeac3 Compare February 23, 2022 11:57
@pauby pauby marked this pull request as ready for review February 23, 2022 11:57
@pauby
Copy link
Member Author

pauby commented Feb 23, 2022

@AdmiringWorm This is ready for review again.

@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@pauby pauby changed the title (libreoffice) Clarify where to raise issues / questions (libreoffice) Clarify package update lagging behind software release and where to raise issues / questions Feb 23, 2022
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit eeb152c into chocolatey-community:master Feb 25, 2022
@AdmiringWorm
Copy link
Member

@pauby your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(libreoffice-fresh) Outdated
3 participants