Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(webstorm) When installing a new WebStorm minor version (e.g. 2023.2.0), an empty directory under Program Files (x86)\JetBrains\WebStorm 2023.2.0 is created #2266

Closed
9numbernine9 opened this issue Jul 31, 2023 · 5 comments · May be fixed by #2367
Closed

(webstorm) When installing a new WebStorm minor version (e.g. 2023.2.0), an empty directory under Program Files (x86)\JetBrains\WebStorm 2023.2.0 is created #2266

9numbernine9 opened this issue Jul 31, 2023 · 5 comments · May be fixed by #2367
Labels
Bug Pending closure Unresolved

Comments

@9numbernine9
Copy link

Chocolatey Version

2.2.0

Chocolatey License

None

Package Version

2023.2.0

Current Behaviour

Hello!

When installing the latest version of WebStorm (2023.2.0), line 9 sets the $installDir variable to $programFiles\JetBrains\WebStorm $env:ChocolateyPackageVersion. Unfortunately, this value is not quite correct for new WebStorm minor versions: when a WebStorm version number ends in .0, the directory that the WebStorm installer will install itself into will omit the .0 patch version.

The end result of this is that we end up with two directories under Program Files (x86):

  • Program Files (x86)\JetBrains\WebStorm 2023.2, where the installer installed itself and placed all the code.
  • Program Files (x86)\JetBrains\WebStorm 2023.2.0, an empty directory created by the ChocolateyInstall.ps1 script.

Although this doesn't cause any errors, it is slightly confusing.

Expected Behaviour

Only one directory for a WebStorm install should be created, not two.

Steps To Reproduce

  • Install WebStorm 2023.2.0 via Chocolatey.
  • In Windows Explorer, go to C:\Program Files (x86)\JetBrains
  • Observe that there are two similar directories: WebStorm 2023.2 ✅ and WebStorm 2023.2.0 ❌

Environment

- Operating System: Microsoft Windows NT 10.0.19045.0
- PowerShell Version: 5.1.19041.3031
- Shell: cmd

Chocolatey Log

N/A

Anything else?

This is essentially the same issue that appears in version 2023.2.0 of the DataGrip package discussed here:
#2257
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue will be closed in 14 days if it continues to be inactive.

@9numbernine9
Copy link
Author

Still relevant.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue will be closed in 14 days if it continues to be inactive.

Please do not add a comment to circumvent automatic closure unless you plan to help move it forward.
Doing this may lead to the issue being closed immediately instead.

9numbernine9 added a commit to 9numbernine9/choco-packages that referenced this issue Dec 7, 2023
@9numbernine9
(webstorm) Strip .0 suffix from installation directory
88613bb 
When determining the installation directory for Datagrip, remove
any `.0` suffix that might be present in the version number.
Jetbrains doesn't use this part of the release version number when
installing, so this causes Chocolatey to create an empty
directory that never gets used or cleaned up.

Fixes issue chocolatey-community#2266 .
9numbernine9 added a commit to 9numbernine9/choco-packages that referenced this issue Dec 7, 2023
@9numbernine9
(webstorm) Strip .0 suffix from installation directory
15a2526 
When determining the installation directory for Webstorm, remove
any `.0` suffix that might be present in the version number.
Jetbrains doesn't use this part of the release version number when
installing, so this causes Chocolatey to create an empty
directory that never gets used or cleaned up.

Fixes issue chocolatey-community#2266 .
@9numbernine9 9numbernine9 mentioned this issue Dec 7, 2023
Open
11 tasks
@github-actions GitHub Actions
Copy link

Dear contributor,

As this issue seems to have been inactive for quite some time now, I've automatically closed it.
If you feel this is a valid issue, please feel free to re-open the issue if/when a pull request
has been added.
Thank you for your contribution.

@9numbernine9
Copy link
Author

Still relevant - PR was raised so I'm not sure why this issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Pending closure Unresolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(webstorm) Strip .0 suffix from installation directory 9numbernine9/choco-packages
1 participant
@9numbernine9