Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Implementing unit tests for language server #6

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

AdmiringWorm
Copy link
Member

Description

This PR adds unit tests for the language server

Related Issue

No related issue (yet)

Motivation and Context

To validate that the rules work as expected (mainly)

How Has This Been Tested?

Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Unit Tests

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. (this is the purpose of this PR)
  • All new and existing tests passed.

@AdmiringWorm AdmiringWorm added this to the 0.1.0 milestone Jan 24, 2020
@AdmiringWorm
Copy link
Member Author

Odd, I ran this locally and it succeeded. Will try changing the language version to see if it helps.

@AdmiringWorm
Copy link
Member Author

@gep13 @mkevenaar I have gotten started on implementing unit tests for the language server.
I have created the 'unit-tests' branch for this purpose, so we all are able to add new unit tests more easily.

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@f25f175). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop       #6   +/-   ##
==========================================
  Coverage           ?   41.92%           
==========================================
  Files              ?       37           
  Lines              ?      675           
  Branches           ?      155           
==========================================
  Hits               ?      283           
  Misses             ?      370           
  Partials           ?       22
Impacted Files Coverage Δ
...rce/chocolatey-language-server/Models/MetaValue.cs 75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25f175...c7589d9. Read the comment docs.

@AdmiringWorm AdmiringWorm force-pushed the unit-tests branch 2 times, most recently from 5d61400 to 604d94f Compare January 25, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants