Initial working #11
Draft
Initial working #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We won't be able to test these changes on appveyor before the target branch have updated the appveyor image used to "Visual Studio 2019" (appveyor don't use the appveyor.yml file in a pr, only the one on the target branch). |
AdmiringWorm
force-pushed
the
runtime-generation
branch
from
88eb6fb
to
e3895c9
Compare
|
I re-implemented the nuget package creation to better conform to creating packages for multiple runtimes (since we can use the same nuspec file for each runtime). |
This allows us to use a single nuspec file for creating all of the supported runtimes
gep13
force-pushed
the
runtime-generation
branch
from
e3895c9
to
6897980
Compare
|
@AdmiringWorm thank you very much for taking a look at this! The refactoring that you have done is a stroke of genius! I have rebased this branch on the latest develop, which is now running on the right AppVeyor base image, and the build is now working. There is still a little bit of re-work to be done here, but basically it seems to be working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.