Add hook package for pester test validation #8
Conversation
This commit adds a hook package to this repository which executes any pester tests that have been included in a tests folder inside the package. Package parameters are provided to allow skipping of execution of the pester tests to allow for other hooks that may be required to run as opposed to using the global --skip-hooks parameter.
| <description>This hook package adds scripts that execute Pester tests for a package after the execution of `chocolateyInstall.ps1`. | ||
| To run validation include pester tests inside a `tests` folder inside the package. | ||
|
|
||
| ## Package Parameters: |
There was a problem hiding this comment.
This could be read as package parameters available while installing pester-validation.hook, not package parameters available when the hook is already installed.
| } | ||
|
|
||
| if ($testDir) { | ||
| if (-not $pp['SkipPackageValidation']) { |
There was a problem hiding this comment.
When writing the hooks, I had not really considered usage of package parameters. This was due to concerns of conflicts between parameters for packages, and parameters for hooks. There are some packages on CCR where the parsing of parameters is not ideal, and they could potentially have issues with unexpected parameters, who knows how many internal packages could have issues. Also, if a package parameter has an arbitrary name, it could set something in both a hook and the package, where only one was intended.
Currently, there is the --skip-hooks, which I had though should take care of disabling hooks when needed. Then for configuration, after discussion with @gep13, using the Chocolatey configuration file to store configuration values was the best option for configuring hooks. Use the choco config command to set, and use a helper to read the values (PR here chocolatey/choco#2952).
I had thought that most hooks would be "install and forget", or "configure once and forget", but it looks like that might not be the case. Maybe we need to add a switch to Chocolatey to skip individual hooks, or this hook could be switched to use a configuration value? I'd welcome other thoughts on this.
This PR adds a hook package to this repository which allows for the execution of pester tests from within a
testsfolder included in a Chocolatey package.