Use chocolatey package for upgrade #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 2, 2020 16:34
(even if the upgrade attribute is set to true)
Otherwise the pipeline fails on this command with the following error message: > Chef Development Kit cannot execute without accepting the license It seems the command-line option to accept the licens can't be placed such that it isn't erroneously interpreted as a subcommand (whether before or after the exec subcommand), so I went with the environment variable instead, which does seem to work correctly.
|
In case anyone is currently looking at this PR: I am going to squash the fixup commit into the preceding commit, so there will be a force push. |
zeusttu
force-pushed
the
use-chocolatey_package-for-upgrade
branch
from
f558f55
to
2d171d9
Compare
|
I'd prefer to use a if/else statement so there's only 1 resource showing in the logs, but this will work. I can clean it up locally. Thanks for getting this going @zeusttu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to the
chocolatey_packageresource for upgrading an existing installation, because it seems to be more robust than Chocolatey's install script.Added bonus: I also fixed the AppVeyor pipeline, which was failing because the Chef license was not being accepted.
Issues Resolved
#12, #144
Check List
masterbranch (thechocolatey.install_vars.chocolateyVersionattribute seems to be ignored when installing Chocolatey).