Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#29) Add missing release notes to generated packages #41

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This adds a version substitution to the nuspec file to automatically
insert the version to the release notes link when a package is
generated.

Motivation and Context

We want to have a link to the release notes when we push a package to the Chocolatey Community Repository.

Testing

  1. Run .\build.ps1.
  2. Navigate to code_drop\Packages\Chocolatey.
  3. Extract the nupkg file.
  4. Open up the nuspec file.
  5. Ensure that the release notes element have the version number specified in the URL.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #29

@AdmiringWorm AdmiringWorm self-assigned this Jan 29, 2024
Copy link
Contributor

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…ages

This adds a version substitution to the nuspec file to automatically
insert the version to the release notes link when a package is
generated.
@corbob corbob force-pushed the 29-Add-missing-release-notes-to-generated-packages branch from b1154aa to 5f76171 Compare February 1, 2024 17:31
@corbob corbob enabled auto-merge February 1, 2024 17:31
@corbob corbob merged commit 5f67c30 into chocolatey-community:develop Feb 1, 2024
1 check passed
@AdmiringWorm AdmiringWorm deleted the 29-Add-missing-release-notes-to-generated-packages branch February 1, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing release notes to generated packages
2 participants