Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better manage concurrency while fixing choco #62

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Thilas
Copy link

@Thilas Thilas commented May 23, 2024

Description Of Changes

With this change, a mutex ensures that only one job can run fix_choco. So potentially no more directory removed while being used.

I also:

  • dropped the random waiting time because no longer required
  • fix a small bug where fix_choco was ran once every 2 days instead of 1 day as mentioned in the code

Motivation and Context

Regularly AU update scripts fails because it can't find some chocolatey cmdlets. I came to think that it might be because of how AU fix_choco works.

Testing

I tested the changes a year ago and I've been using it on all my packages since then. As a result, I never got any issue so far.

Operating Systems Testing

  • Windows 11
  • Windows Server 2022

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Supersedes #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant