Make GTEST location configurable. #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GTEST_LIBDIR and GTEST_INCDIR are now configurable as parameters to make, which makes it easier to use the gtest library already on the system and not needing the one from third_party/. Also: invoke yosys from YOSYS_PATH instead of just system `yosys`, as these might be two different things. Signed-off-by: Henner Zeller <[email protected]>
|
I like the solution WIP in #485 by @timkpaine to remove that awkward local building of gtest entirely. Better way to do it. Tim, might be useful to break out as separate PR. Will close my PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTEST_LIBDIR and GTEST_INCDIR are now configurable as parameters to make, which makes it easier to use the gtest library already on the system and not needing the one from third_party/.
Also: invoke yosys from YOSYS_PATH instead of just system
yosys, as these might be two different things.