Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unidoc was apparently not running in CI and it was broken by #2277. The issue isn't that #2277 is broken, it's that it exposed the fact that
unidoc
actually runs the same scalacOptions on all of the files being built into 1 doc. This is a problem because Chisel3core
needs to not have the compiler plugin run on it, while the downstreamchisel
project does. This is a hacky solution, but it's the best I have, see sbt/sbt-unidoc#107.Note that this has 3 useful commits. There is a little of refactoring of how the plugin skips components (a component is a Scalac compiler phase).
Contributor Checklist
docs/src
?Type of Improvement
API Impact
This adds an argument to the chisel3 plugin
-P:chiselplugin:INTERNALskipFile:<filename>
, note this is only intended to be used for internalunidoc
generation.Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.3.x
, [small] API extension:3.4.x
, API modification or big change:3.5.0
)?Please Merge
?