Allow helm --debug to be conditionally rendered
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erchn
approved these changes
Jul 8, 2024
d1egoaz
approved these changes
Jul 8, 2024
| @@ -226,6 +226,7 @@ func main() { | |||
| skipRenderKey := flag.String("skip-render-key", "do-not-render", "Key to not render") | |||
| ignoreValueFile := flag.String("ignore-value-file", "overrides-to-ignore", "Override file to ignore based on filename") | |||
| postRenderer := flag.String("post-renderer", "", "When provided, binary will be called after an application is rendered.") | |||
| debug := flag.Bool("debug", false, "When true provides additional logs.") | |||
There was a problem hiding this comment.
I wonder if we could add a way (this or other PR) to pass this and any other additional arguments to Helm, something like additionalArgs="--debug --other=x" 🤷
BTW, you could also set HELM_DEBUG to enable debugging 🤷
There was a problem hiding this comment.
@d1egoaz - I'll work on getting additionalHelmArgs added 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for debug logs to be rendered when using this tool.
Ex.: