New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninitialised variable warning in GaussianQuadrature #458

Merged

jacklovell merged 1 commit into cherab:development from vsnever:fix/uninitialised_variable_in_quadrature

Aug 2, 2024

Member

vsnever commented Aug 2, 2024

This PR simply fixes a warning caused by returning a potentially uninitialized variable in GaussianQuadrature.evaluate():

cherab/core/math/integrators/integrators1d.c: In function ‘__pyx_f_6cherab_4core_4math_11integrators_13integrators1d_18GaussianQuadrature_evaluate’:
cherab/core/math/integrators/integrators1d.c:31196:10: warning: ‘__pyx_v_newval’ may be used uninitialized in this function [-Wmaybe-uninitialized]
31196 |   return __pyx_r;


          Fix uninitialised variable warning in GaussianQuadrature.

a501470

Mateasek approved these changes

View reviewed changes

Member

Mateasek left a comment

good cactch @vsnever

jacklovell merged commit 3e0f352 into cherab:development

8 checks passed

vsnever deleted the fix/uninitialised_variable_in_quadrature branch

August 30, 2024 16:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet